Home » Renegade Discussions » Mod Forum » Function Hooking
Function Hooking [message #490115] |
Wed, 24 December 2014 13:26 |
Neijwiert
Messages: 124 Registered: October 2009
Karma:
|
Recruit |
|
|
I've been trying and trying but I just cannot figure it out. I even asked it on StackOverflow but they aren't helping much either.
What I'm trying to achieve is: Call a custom (hook) function and then calling the original function (a trampoline effect, whilst keeping the stack intacked between the functions).
I did somehow achieve this when I hooked into the Commands->Find_Object function, I intercepted all calls to it and it worked fine. So I was all happy and satisfied how that worked out and I tried to put everything in a nice class. When I did that it just stoped working. So I was like, well yeah that sometimes happens you mess up some simple thing whilst copying it over. So I moved everything back to the old (messy) code and to my surprise that stoped working aswell...
My new code is actually pretty much a complete mirror and I doubt that the copy pasting went wrong so I'm just gonna put that version here in the hopes somebody of the renegade community can help me to find the problem.
I have the following header file:
Toggle Spoiler
#ifndef TIMEMACHINE_INCLUDE__DETOURS_H
#define TIMEMACHINE_INCLUDE__DETOURS_H
#define Detours DetourClass::Get_Instance()
class DetourClass
{
friend class TimeMachine;
private:
struct DetourFunction
{
DetourFunction(ULONG ID, BYTE *OriginalFunction, BYTE *HookFunction, BYTE *OriginalFunctionCode)
{
this->ID = ID;
this->OriginalFunction = OriginalFunction;
this->HookFunction = HookFunction;
this->OriginalFunctionCode = OriginalFunctionCode;
}
~DetourFunction()
{
free(this->OriginalFunctionCode);
}
ULONG ID;
BYTE *OriginalFunction;
BYTE *HookFunction;
BYTE *OriginalFunctionCode;
};
public:
ULONG Install_Detour(BYTE *TargetAddress, BYTE *HookAddress);
void Remove_Detour(ULONG ID);
void Remove_All_Detours();
long Jump_To_Original(ULONG ID);
static DetourClass *Get_Instance();
protected:
DetourClass();
~DetourClass();
static DetourClass *Instance;
private:
int Calculate_Offset_Address(BYTE *StartAddress, BYTE *TargetAddress);
ULONG _FreeID;
SimpleDynVecClass<DetourFunction *> _Functions;
};
#endif
Which has the following source file:
Toggle Spoiler
#include "General.h"
#include "engine.h"
#include "Detours.h"
static const unsigned int JMP32_SZ = 5; // the size of JMP <address>
static const unsigned int NOP = 0x90; // opcode for NOP
static const unsigned int JMP = 0xE9; // opcode for JUMP
DetourClass::DetourClass()
{
this->_FreeID = 1;
}
DetourClass::~DetourClass()
{
Remove_All_Detours();
}
#pragma optimize( "", off )
ULONG DetourClass::Install_Detour(BYTE *TargetAddress, BYTE *HookAddress)
{
DWORD OldProtect;
if (!VirtualProtect(TargetAddress, JMP32_SZ, PAGE_EXECUTE_READWRITE, &OldProtect)) // Make sure we are allowed to modify that memory area
{
return 0;
}
BYTE *OriginalCode = (BYTE *)malloc(JMP32_SZ); // Reserve space to store the overwritten data of the original part
memcpy(OriginalCode, TargetAddress, JMP32_SZ); // Copy original part of the function
memset(TargetAddress, NOP, JMP32_SZ); // Good practice to NOP original part
// Insert a jump to the hook function in the original code
int HookJumpOffset = Calculate_Offset_Address(TargetAddress, HookAddress);
TargetAddress[0] = JMP;
memcpy(TargetAddress + 1, &HookJumpOffset, 4);
///////////////////////////////////////////////////////////////////////////////
VirtualProtect(TargetAddress, JMP32_SZ, OldProtect, NULL);
ULONG NewID = this->_FreeID++;
this->_Functions.Add(new DetourFunction(NewID, TargetAddress, HookAddress, OriginalCode));
return NewID;
}
#pragma optimize( "", on )
void DetourClass::Remove_Detour(ULONG ID)
{
if (ID == 0)
{
return;
}
for (int x = this->_Functions.Count() - 1; x >= 0; x--)
{
DetourFunction *CurFunction = this->_Functions[x];
if (CurFunction->ID == ID) // Check if the current detour has the same target as the one we're trying to remove
{
this->_Functions.Delete(x); // Remove that one
// Try to restore to old situation
DWORD OldProtect;
if (VirtualProtect(CurFunction->OriginalFunction, JMP32_SZ, PAGE_EXECUTE_READWRITE, &OldProtect))
{
memcpy(CurFunction->OriginalFunction, CurFunction->OriginalFunctionCode, JMP32_SZ); // Copy original code back
VirtualProtect(CurFunction->OriginalFunction, JMP32_SZ, OldProtect, NULL);
}
///////////////////////////////////////////////////////////////////////////////
delete CurFunction; // Free up resources
return;
}
}
}
void DetourClass::Remove_All_Detours()
{
for (int x = this->_Functions.Count() - 1; x >= 0; x--)
{
DetourFunction *CurFunction = this->_Functions[x];
// Try to restore to old situation
DWORD OldProtect;
if (VirtualProtect(CurFunction->OriginalFunction, JMP32_SZ, PAGE_EXECUTE_READWRITE, &OldProtect))
{
memcpy(CurFunction->OriginalFunction, CurFunction->OriginalFunctionCode, JMP32_SZ); // Copy original code back
VirtualProtect(CurFunction->OriginalFunction, JMP32_SZ, OldProtect, NULL);
}
///////////////////////////////////////////////////////////////////////////////
delete CurFunction; // Free up resources
}
this->_Functions.Delete_All();
}
long DetourClass::Jump_To_Original(ULONG ID)
{
if (ID == 0)
{
return NULL;
}
for (int x = this->_Functions.Count() - 1; x >= 0; x--)
{
DetourFunction *CurFunction = this->_Functions[x];
if (CurFunction->ID == ID)
{
BYTE *ASMCode = (BYTE *)VirtualAlloc(0, JMP32_SZ + JMP32_SZ, MEM_COMMIT, PAGE_EXECUTE_READWRITE); // Reserve space for run-time generated asm code
memcpy(ASMCode, CurFunction->OriginalFunctionCode, JMP32_SZ); // Copy the original code to the beginning
int OriginalJumpOffset = Calculate_Offset_Address(ASMCode + JMP32_SZ, CurFunction->OriginalFunction + JMP32_SZ); // Calculate jump offset to original function
ASMCode[JMP32_SZ] = JMP; // Insert the jump opcode
memcpy(ASMCode + JMP32_SZ + 1, &OriginalJumpOffset, 4); // Copy the jump address
long ReturnValue = ((long(*)(void))ASMCode)(); // Execute the code and get the return value (if any)
VirtualFree(ASMCode, JMP32_SZ + JMP32_SZ, MEM_DECOMMIT); // Free the code
return ReturnValue;
}
}
return NULL;
}
DetourClass *DetourClass::Get_Instance()
{
return DetourClass::Instance;
}
int DetourClass::Calculate_Offset_Address(BYTE *StartAddress, BYTE *TargetAddress)
{
return (((int)TargetAddress - (int)StartAddress) - JMP32_SZ);
}
DetourClass *DetourClass::Instance = NULL;
In my plugin source file I have these calls to the DetourClass:
Toggle Spoiler
ULONG ObjectHookID = 0;
ULONG FooHookID = 0;
int Foo()
{
Console_Output("Normal Foo\n");
return 5;
}
int Foo_Hook()
{
Console_Output("Hook Foo\n");
return (int)Detours->Jump_To_Original(FooHookID);
}
GameObject *Find_Object_Hook(int obj_id)
{
Console_Output("Finding object with id: %d\n", obj_id);
return (GameObject *)Detours->Jump_To_Original(ObjectHookID);
}
TimeMachine::TimeMachine()
{
DetourClass::Instance = new DetourClass();
RegisterEvent(EVENT_LOAD_LEVEL_HOOK, this);
//ObjectHookID = Detours->Install_Detour(&Commands->Find_Object, &Find_Object_Hook);
FooHookID = Detours->Install_Detour((BYTE *)&Foo, (BYTE *)&Foo_Hook);
if (FooHookID == 0)
{
Console_Output("Install failed\n");
}
}
TimeMachine::~TimeMachine()
{;
delete DetourClass::Instance;
UnregisterEvent(EVENT_LOAD_LEVEL_HOOK, this);
Console_Output(__FUNCTION__ "\n");
}
void TimeMachine::OnLoadLevel()
{
Console_Output("%d\n", Foo());
}
Where TimeMachine is my plugin class (So the constructor gets called when SSGM loads the library). I have checked if the memory is actually changed after my function calls and it is indeed changed to the correct variables. But as soon as I call Foo() it just executes it as if nothing changed. The reason that I have it in OnLoadLevel is becouse in one of my earlier tests it started working when I moved it to OnLoadLevel (so outside the constructor). The reason why I'm not trying to hook Find_Object right now is becouse when internal engine calls go to Find_Object when the game starts it crashes the fds instantly (The hooking in the constructor goes without any problems).
If somebody comes up with a solution or pushes me in the right direction that would be greatly apreciated!
|
|
|
Goto Forum:
Current Time: Sun Dec 01 11:37:17 MST 2024
Total time taken to generate the page: 0.00858 seconds
|