Command and Conquer: Renegade Official Forums: Tiberian Technologies Forum

Home » Tiberian Technologies / Blackhand Studios » Tiberian Technologies Forum » Vehicle WEAPON names no longer shows up

Show: Today's Messages :: Polls :: Message Navigator

Re: Vehicle WEAPON names no longer shows up [message #487437 is a reply to message #487436]

Wed, 30 April 2014 21:43

Jerad2142
Messages: 3813
Registered: July 2006
Location: USA

Karma:

General (3 Stars)

jonwil wrote on Wed, 30 April 2014 15:58

I cant remember why I made the change.
Based on a reading of TranslateDBClass::Find_Object(uint32 id) in TranslateDBClass.h and other stuff in TranslateDBClass.h, the correct way to do what I was doing would have been to do something like this:

const wchar_t *VehicleGameObj::Get_Vehicle_Name()
{
	if (( Get_Definition().VehicleNameID != 0 ) && (Get_Definition().VehicleNameID-1000 < TranslateDBClass::Get_Object_Count())) {
		return TranslateDBClass::Get_String( Get_Definition().VehicleNameID );
	}
	return TRANSLATE(12648);
}

In the case of BeaconGameObj.cpp, its correctly subtracting 1000 (aka ID_MIN) before doing the comparison.
Checking tdbedit, it looks like Goto in tdbedit.cpp (based on the things that call it) is supposed to take an index into the TranslateDBClass array and therefore is doing what it should be doing.

So in theory if you make sure that there is a string with an ID that's at least 1000 more than the IDs you are using for your weapon strings, it SHOULD work. (hence why it works for other people)

As for an actual fix, I will commit a fix to 5.0 (where work is going forward) and to 4.2 (our stable branch) but we wont be releasing a fix for 4.1 at this time.

Sounds good thanks, for a second I thought you were going to make me add 100 id's just to make this work lol.

Visit Jerad's deer sweat shop

Report message to a moderator

[Message index]

		Vehicle WEAPON names no longer shows up By: Jerad2142 on Tue, 29 April 2014 08:41
		Re: Vehicle WEAPON names no longer shows up By: danpaul88 on Tue, 29 April 2014 09:20
		Re: Vehicle WEAPON names no longer shows up By: Jerad2142 on Tue, 29 April 2014 10:30
		Re: Vehicle WEAPON names no longer shows up By: danpaul88 on Tue, 29 April 2014 12:11
		Re: Vehicle WEAPON names no longer shows up By: Jerad2142 on Tue, 29 April 2014 14:06
		Re: Vehicle WEAPON names no longer shows up By: danpaul88 on Tue, 29 April 2014 14:35
		Re: Vehicle WEAPON names no longer shows up By: Jerad2142 on Wed, 30 April 2014 06:34
		Re: Vehicle WEAPON names no longer shows up By: jonwil on Tue, 29 April 2014 16:53
		Re: Vehicle WEAPON names no longer shows up By: danpaul88 on Wed, 30 April 2014 06:44
		Re: Vehicle WEAPON names no longer shows up By: Jerad2142 on Wed, 30 April 2014 06:51
		Re: Vehicle WEAPON names no longer shows up By: danpaul88 on Wed, 30 April 2014 06:54
		Re: Vehicle WEAPON names no longer shows up By: Jerad2142 on Wed, 30 April 2014 07:27
		Re: Vehicle WEAPON names no longer shows up By: danpaul88 on Wed, 30 April 2014 07:30
		Re: Vehicle WEAPON names no longer shows up By: iRANian on Wed, 30 April 2014 07:50
		Re: Vehicle WEAPON names no longer shows up By: danpaul88 on Wed, 30 April 2014 08:12
		Re: Vehicle WEAPON names no longer shows up By: Jerad2142 on Wed, 30 April 2014 09:42
		Re: Vehicle WEAPON names no longer shows up By: danpaul88 on Wed, 30 April 2014 13:44
		Re: Vehicle WEAPON names no longer shows up By: jonwil on Wed, 30 April 2014 14:58
		Re: Vehicle WEAPON names no longer shows up By: Jerad2142 on Wed, 30 April 2014 21:43
		Re: Vehicle WEAPON names no longer shows up By: danpaul88 on Thu, 01 May 2014 01:28
		Re: Vehicle WEAPON names no longer shows up By: jonwil on Thu, 01 May 2014 03:20
		Re: Vehicle WEAPON names no longer shows up By: danpaul88 on Thu, 01 May 2014 04:18
		Re: Vehicle WEAPON names no longer shows up By: Jerad2142 on Thu, 01 May 2014 06:57
		Re: Vehicle WEAPON names no longer shows up By: danpaul88 on Thu, 01 May 2014 07:06
		Re: Vehicle WEAPON names no longer shows up By: Jerad2142 on Thu, 01 May 2014 07:30

Previous Topic:	Feature request, clients update objectives
Next Topic:	tdbedit.exe fails to list the strings I have under the default tab in my strings file.

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Jan 31 22:46:35 MST 2025

Total time taken to generate the page: 0.00882 seconds